Uploaded image for project: 'OpenShift API for Data Protection'
  1. OpenShift API for Data Protection
  2. OADP-5030

Backups without velero.config section in DPA result in plugin panic.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • OADP 1.5.0
    • OADP 1.3.4
    • dpa
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • ToDo
    • 0
    • 0.000
    • Very Likely
    • 0
    • None
    • Unset
    • Unknown
    • None

      Description of problem:

      Without the BSL velero.config section in the DPA yaml, the backup results in plugin panic.

      Version-Release number of selected component (if applicable):

      1.4.1

      How reproducible:

      Always (Not visible on AZURE, as DPA doesnt reconcile without config.resourceGroup in azure case.)

      Steps to Reproduce:
      1. Create DPA without velero.config section in DPA's BSL
      2. Perform backup of any application.

      Actual results:

      Backup Partially Fails with panic.

      $ velero backup describe secondcase1 -n openshift-adp
      Name:         secondcase1
      Namespace:    openshift-adp
      Labels:       velero.io/storage-location=ts-dpa-1
      Annotations:  velero.io/resource-timeout=10m0s
                    velero.io/source-cluster-k8s-gitversion=v1.29.8+632b078
                    velero.io/source-cluster-k8s-major-version=1
                    velero.io/source-cluster-k8s-minor-version=29
      
      Phase:  PartiallyFailed (run `velero backup logs secondcase1` for more information)
      
      
      Errors:
        Velero:   name: /django-psql-persistent message: /Error backing up item error: /error executing custom action (groupResource=imagestreams.image.openshift.io, namespace=django, name=django-psql-persistent): rpc error: code = Aborted desc = plugin panicked: assignment to entry in nil map, stack trace: goroutine 55 [running]:
      runtime/debug.Stack()
        /usr/lib/golang/src/runtime/debug/stack.go:24 +0x5e
      github.com/vmware-tanzu/velero/pkg/plugin/framework/common.HandlePanic({0x23dd140?, 0x2f5bfe0})
        /remote-source/deps/gomod/pkg/mod/github.com/openshift/velero@v0.10.2-0.20230927152659-2a19a7bf1ac3/pkg/plugin/framework/common/handle_panic.go:43 +0xd1
      github.com/vmware-tanzu/velero/pkg/plugin/framework.(*BackupItemActionGRPCServer).Execute.func1()
        /remote-source/deps/gomod/pkg/mod/github.com/openshift/velero@v0.10.2-0.20230927152659-2a19a7bf1ac3/pkg/plugin/framework/backup_item_action_server.go:86 +0x2a
      panic({0x23dd140?, 0x2f5bfe0?})
        /usr/lib/golang/src/runtime/panic.go:770 +0x132
      github.com/konveyor/openshift-velero-plugin/velero-plugins/imagestream.getAWSRegistryEnvVars(0xc000a18c40)
        /remote-source/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/imagestream/registry.go:137 +0xe9
      github.com/konveyor/openshift-velero-plugin/velero-plugins/imagestream.getRegistryEnvVars(0xc000572bd8?)
      

      Expected results:

      Backup should be successful.

      Additional info:

      DPA:

      $ oc get dpa -o yaml
      apiVersion: v1
      items:
      - apiVersion: oadp.openshift.io/v1alpha1
        kind: DataProtectionApplication
        metadata:
          creationTimestamp: "2024-10-11T17:05:28Z"
          generation: 12
          name: ts-dpa
          namespace: openshift-adp
          resourceVersion: "271234"
          uid: 4aa4e26d-a4aa-4643-b3ce-d3471b63308e
        spec:
          backupLocations:
          - velero:
              credential:
                key: cloud
                name: cloud-credentials
              default: true
              objectStorage:
                bucket: oadp98581bxgnc
                prefix: velero
              provider: aws
          configuration:
            nodeAgent:
              enable: true
              uploaderType: kopia
            velero:
              defaultPlugins:
              - aws
              - openshift
          snapshotLocations:
          - velero:
              config:
                profile: default
                region: us-east-2
              provider: aws
        status:
          conditions:
          - lastTransitionTime: "2024-10-11T17:05:48Z"
            message: Reconcile complete
            reason: Complete
            status: "True"
            type: Reconciled
      kind: List
      metadata:
        resourceVersion: ""
      

              wnstb Wes Hayutin
              rhn-support-ssingla Sachin Singla
              Sachin Singla Sachin Singla
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: