Uploaded image for project: 'OpenShift API for Data Protection'
  1. OpenShift API for Data Protection
  2. OADP-4744

[Scale] Benchmark-runner-assistant enable ability to label runs

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • Scale&Perf-QE
    • None
    • 4
    • False
    • Hide

      None

      Show
      None
    • False
    • ToDo
    • 0
    • 0.000
    • Very Likely
    • 0
    • None
    • Unset
    • Unknown
    • None

      tracker for https://gitlab.cee.redhat.com/mlehrer/mpqe-scale-scripts/-/issues/46

       

      benchmark runner allows for results to be labeled by passing the following values --oadp-label-name=somestring --oadp-label-value=somevalue

      It would look something like this:
      PYTHONPATH=. python3 benchmark_runner/main/main.py --oadp_scenario=${cycle} --oadp_cleanup_cr=False --oadp_cleanup_dataset=False --oadp-velero-ns=${oadp_ns} --oadp-label-name=somestring --oadp-label-value=somevalue
      We want somestring and somevalue to come from the cycles_list.txt
      So in the following cycle list example all of the following cases are valid:
      backup-csi-datagen-single-ns-100pods-cephrbd testtype 1st-run
      backup-csi-datagen-single-ns-100pods-cephrbd testtype 2nd-run
      backup-csi-datagen-single-ns-100pods-cephrbd testtype final-run
      backup-csi-datagen-single-ns-100pods-cephrbd bestjoketype knock-knock
      backup-csi-datagen-single-ns-100pods-cephrbd{{}}
      This means that after the scenario name the first non-whitespace value is the --oadp-label-name value and the next non-whitespace value is --oadp-label-value

      So we need to make the following changes:

      check if $cycles in cycles_list contains a spaces

      • if it does contains a spaces then split the line into an array
      • set $cycle = first value in array
      • use --oadp-label-name for second value in array and --oadp-label-value for 3rd value in line
        PYTHONPATH=. python3 benchmark_runner/main/main.py --oadp_scenario=${cycle} --oadp_cleanup_cr=False --oadp_cleanup_dataset=False --oadp-velero-ns=${oadp_ns} --oadp-label-name=${array_2ndvalue} --oadp-label-value=${array_2ndvalue}{{}}

              tzahia Tzahi Ashkenazi
              mlehrer@redhat.com Mordechai Lehrer
              Mordechai Lehrer Mordechai Lehrer
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: