Uploaded image for project: 'OpenShift API for Data Protection'
  1. OpenShift API for Data Protection
  2. OADP-225

Restore doesn't update velero.io/backup-name when a resource is updated

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Normal
    • OADP 1.1.0
    • OADP 1.0.2
    • velero
    • False
    • False
    • ToDo
    • -
    • OADP Sprint 215, OADP Sprint 216, OADP Sprint 217, OADP Sprint 218
    • 4
    • 0
    • 0
    • 0
    • Untriaged

    Description

      I looked at the velero restore code ignoring existing resources. What I noticed

      I also noticed that although ServiceAccount objects are being updated, velero labels did not change for velero.io/backup-name= and velero.io/restore-name= ; so this is an issue that needs to be fixed too

      This is a restore log where a ServiceAccount resource was updated based on the new restored version; I checked, velero.io/restore-name was not updated on this resource to match the latest restore and backup names

       

      time="2022-01-13T23:33:35Z" level=info msg="Attempting to restore ServiceAccount: test-vb" logSource="pkg/restore/restore.go:1264" restore=openshift-adp/restore-backup-account-6
      time="2022-01-13T23:33:35Z" level=info msg="ServiceAccount abc-broker/test-vb successfully updated" logSource="pkg/restore/restore.go:1313" restore=openshift-adp/restore-backup-account-6
       
      

      Attachments

        Activity

          People

            spampatt@redhat.com Shubham Pampattiwar
            vbirsan@redhat.com Valentina Birsan
            Amos Mastbaum Amos Mastbaum
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: