Loading...

XML

Word

Printable

Type: Bug
Resolution: Done
Priority: Normal
Fix Version/s: None
Affects Version/s: None
Component/s: Operator
Labels:
- no-qe-needed

Blocked:
False
Blocked Reason:
None
Ready:
False

Sprint:
NetObserv - Sprint 227

SFDC Cases Links:
SFDC Cases Counter:
SFDC Cases Open:

We are not correctly using condition.status field in the operator
https://github.com/netobserv/network-observability-operator/blob/main/pkg/conditions/conditions.go#L17

"ConditionTrue" means a resource is in the condition.
// "ConditionFalse" means a resource is not in the condition. "ConditionUnknown" means kubernetes
// can't decide if a resource is in the condition or not. In the future, we could add other
// intermediate conditions, e.g. ConditionDegraded.

Currently we are putting true when ready and false on errors.
It should be true on current state and false on previous ones.

This is useful to get current condition(s) programatically

We are not getting pending / error components. We should query deployment status to get the real state of operator instead of returning "ready" when everything is created
Update condition should use patch instead of apply especially when concurrent updates occurs https://github.com/netobserv/network-observability-operator/blob/main/controllers/flowcollector_controller.go#L366

is blocked by

NETOBSERV-473 Loki and strimzi operator installation

Closed

is related to

NETOBSERV-665 flowlogs-pipeline is stuck at ContainerCreating and is never ready

Closed

NETOBSERV-793 flowlogs-pipeline is stuck at ContainerCreating when CA cert is misconfigured

Closed

NETOBSERV-1224 Flowcollector does not report status != Ready in OCP Console

Closed

links to

netobserv/network-observability-operator#403: NETOBSERV-1224 Flowcollector does not report status != Ready in OCP Console

mentioned on

Merge request - Updated 3 upstream sources

(1 mentioned on)

Assignee:: Unassigned

Reporter:: Julien Pinsonneau

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 2022/09/29 7:20 AM

Updated:: 2023/09/01 2:02 PM

Resolved:: 2023/02/16 8:29 PM