Uploaded image for project: 'Network Observability'
  1. Network Observability
  2. NETOBSERV-2348

FlowMetrics: lack of validation for prometheus names

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • NetObserv - Sprint 274, NetObserv - Sprint 275
    • None
    • Bug Fix
    • Hide
      Previously, users could create a FlowMetric resource with an invalid metric name. The FlowMetric resource was successfully created, but the underlying metric would silently fail to create.
      With this change, FlowMetric `metricName` and `remap` fields are validated prior to creation, so the user knows immediately if there is an invalid name.
      Show
      Previously, users could create a FlowMetric resource with an invalid metric name. The FlowMetric resource was successfully created, but the underlying metric would silently fail to create. With this change, FlowMetric `metricName` and `remap` fields are validated prior to creation, so the user knows immediately if there is an invalid name.

      There's a lack of validation in FlowMetrics, regarding data fields that are then set as prometheus names.

      Especially:

      • spec.metricName shouldn't allow any character (for instance, prometheus forbids names with hyphens like "my-metric")
      • same with spec.remap, which allows to change the predefined label names

       

       

              jtakvori Joel Takvorian
              jtakvori Joel Takvorian
              None
              None
              None
              Amogh Rameshappa Devapura Amogh Rameshappa Devapura
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: