Uploaded image for project: 'Network Observability'
  1. Network Observability
  2. NETOBSERV-1734

Issues with subnet labels

XMLWordPrintable

    • False
    • None
    • False
    • Hide
      Previously, when configuring custom subnet labels and keeping the OpenShift subnets auto-detection enabled, OpenShift subnets would take precedence over the custom ones, preventing the definition of custom labels for in cluster subnets.
      With this patch, custom defined subnets take precedence, allowing the definition of custom labels for in cluster subnets.
      Show
      Previously, when configuring custom subnet labels and keeping the OpenShift subnets auto-detection enabled, OpenShift subnets would take precedence over the custom ones, preventing the definition of custom labels for in cluster subnets. With this patch, custom defined subnets take precedence, allowing the definition of custom labels for in cluster subnets.
    • NetObserv - Sprint 255, NetObserv - Sprint 256

      Here are the issues I encountered with subnet labels.  Feel free to open separate issues for these two items.

      1. OpenShift auto-detect is enabled by default despite the field being not enabled in Form view and despite what the doc says at https://github.com/netobserv/network-observability-operator/blob/main/docs/FlowCollector.md#flowcollectorspecprocessorsubnetlabels-1

      In Web Console, I am unable to set it to false in Form view.

      2. If OpenShift auto-detect is enabled, custom labels do not work.  Is that intentional?  Since `openShiftAutoDetect` is true by default, it doesn't show up in the YAML, Therefore, it seems like custom labels doesn't work at all until I figured out I have to explicitly set `openShiftAutoDetect` to false.

        1. Capture d’écran du 2024-06-27 13-06-47.png
          Capture d’écran du 2024-06-27 13-06-47.png
          89 kB

            [NETOBSERV-1734] Issues with subnet labels

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Moderate: Network Observability 1.6.1 for OpenShift), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2024:4785

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Moderate: Network Observability 1.6.1 for OpenShift), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:4785

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of netobserv-midstream / Network Observability Operator Midstream on branch network-observability-1.7.0-rhel-9_upstream_2175c7318cdba2bada909a4682ffdd1a:

            Updated US source to: f569dbb NETOBSERV-1734: change subnets order priority (#693)

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of netobserv-midstream / Network Observability Operator Midstream on branch network-observability-1.7.0-rhel-9_ upstream _2175c7318cdba2bada909a4682ffdd1a : Updated US source to: f569dbb NETOBSERV-1734 : change subnets order priority (#693)

            Steven Lee added a comment - - edited

            PR https://github.com/netobserv/network-observability-operator/pull/693 looks good.  Now you are able to define an internal custom name and have predefined names (e.g. Pods, Services) if openShiftAutoDetect is set to true.

            Steven Lee added a comment - - edited PR https://github.com/netobserv/network-observability-operator/pull/693 looks good.  Now you are able to define an internal custom name and have predefined names (e.g. Pods, Services) if openShiftAutoDetect is set to true.

            Amogh Rameshappa Devapura added a comment -

            Verified the custom label taking precedence over "pods" label.

            Cluster details:

            • OCP: 4.16.0-0.nightly-2024-06-27-091410
            • NetObserv operator: v0.0.0-cb15190
            • Loki: 0-click-loki
            • eBPF-agent: main
            • FLP: main
            • ConsolePlugin: main

            Amogh Rameshappa Devapura added a comment - Verified the custom label taking precedence over "pods" label. Cluster details: OCP: 4.16.0-0.nightly-2024-06-27-091410 NetObserv operator: v0.0.0-cb15190 Loki: 0-click-loki eBPF-agent: main FLP: main ConsolePlugin: main

            Joel Takvorian added a comment -

            rhn-support-aramesha  sure, in fact you need to define a subnet label that is in cluster. For instance, use the IP of a pod to set a custom label. Before this PR, the "Pods" label (coming from the auto-detect feature) will take precedence. After this PR, it's your custom label that will take precedence.

            Joel Takvorian added a comment - rhn-support-aramesha   sure, in fact you need to define a subnet label that is in cluster. For instance, use the IP of a pod to set a custom label. Before this PR, the "Pods" label (coming from the auto-detect feature) will take precedence. After this PR, it's your custom label that will take precedence.

            Amogh Rameshappa Devapura added a comment -

            jtakvori Could you suggest a way to go about testing the PR  https://github.com/netobserv/network-observability-operator/pull/693 ?

            Amogh Rameshappa Devapura added a comment - jtakvori Could you suggest a way to go about testing the PR   https://github.com/netobserv/network-observability-operator/pull/693 ?

            Joel Takvorian added a comment -

            Assuming stlee@redhat.com issue is because of the priority, openshift-detected subnets taking precedence over the custom-defined subnets in case of overlap: I opened a PR to reverse the priority: https://github.com/netobserv/network-observability-operator/pull/693

            Joel Takvorian added a comment - Assuming stlee@redhat.com issue is because of the priority, openshift-detected subnets taking precedence over the custom-defined subnets in case of overlap: I opened a PR to reverse the priority: https://github.com/netobserv/network-observability-operator/pull/693

            Amogh Rameshappa Devapura added a comment -

            Hey jtakvori While verifying this bug, I did run the automated test netflow_external_subnet.cy.ts and I dont touch the openShiftAutoDetect netobserv.ts#L212 so not able to reproduce as well

            Amogh Rameshappa Devapura added a comment - Hey jtakvori While verifying this bug, I did run the automated test netflow_external_subnet.cy.ts and I dont touch the openShiftAutoDetect netobserv.ts#L212 so not able to reproduce as well

            Joel Takvorian added a comment -

            Hey rhn-support-aramesha , regarding Steven's point 2, which I can't reproduce : can you see if you reproduce what Steven wrote?

            Joel Takvorian added a comment - Hey rhn-support-aramesha , regarding Steven's point 2, which I can't reproduce : can you see if you reproduce what Steven wrote?

            Amogh Rameshappa Devapura added a comment -

            Verified openShiftAutoDetect toggle is not observed in form view. Ran automated tests for subnet label and it passed. Works as expected!

             ✔  netflow_external_subnet.cy.ts            02:04        1        1        -        -        -

            Cluster details:

            • OCP: 4.16.0-0.nightly-2024-06-27-032944
            • NetObserv operator: v0.0.0-fcf1333
            • Loki: 0-click-loki
            • eBPF-agent: main
            • FLP: main
            • ConsolePlugin: main

            Amogh Rameshappa Devapura added a comment - Verified openShiftAutoDetect toggle is not observed in form view. Ran automated tests for subnet label and it passed. Works as expected! ✔  netflow_external_subnet.cy.ts            02:04        1        1        -        -        - Cluster details: OCP: 4.16.0-0.nightly-2024-06-27-032944 NetObserv operator: v0.0.0-fcf1333 Loki: 0-click-loki eBPF-agent: main FLP: main ConsolePlugin: main

              jtakvori Joel Takvorian
              stlee@redhat.com Steven Lee
              Amogh Rameshappa Devapura Amogh Rameshappa Devapura
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: