Uploaded image for project: 'Migration Toolkit for Virtualization'
  1. Migration Toolkit for Virtualization
  2. MTV-1856

Not handling OVA NFS URL if it does not contain ":" char

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • 2.7.8
    • None
    • Controller
    • False
    • None
    • True

      In our code:
      https://github.com/kubev2v/forklift/blob/main/pkg/controller/provider/ova-setup.go#L74

      we do not handle the case of missing ":" in the NFS URL
      this will create an unhanded error:

      {"level":"info","ts":"2024-12-29 10:46:32.872","msg":"Observed a panic in reconciler: runtime error: index out of range [1] with length 1","controller":"provider","object":\{"name":"ova-server","namespace":"ova-server"}

      ,"namespace":"ova-server","name":"ova-server","reconcileID":"6322e786-c0cd-42eb-b05c-32d644704caa"}

      How to reproduce:
      Create/Edit a OVA provider with URL that does not have ":" in it's URL string

        1. image-2025-01-10-17-34-54-806.png
          14 kB
          Chenli Hu
        2. image-2025-01-10-17-37-34-777.png
          45 kB
          Chenli Hu
        3. image-2025-01-13-11-07-45-713.png
          86 kB
          Chenli Hu
        4. image-2025-01-14-10-42-42-875.png
          84 kB
          Chenli Hu
        5. image-2025-01-14-10-43-48-936.png
          56 kB
          Chenli Hu
        6. image-2025-01-14-11-29-50-533.png
          35 kB
          Chenli Hu

              yzamir@redhat.com Yaacov Zamir
              yzamir@redhat.com Yaacov Zamir
              Chenli Hu Chenli Hu
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: