Uploaded image for project: 'OpenShift Monitoring'
  1. OpenShift Monitoring
  2. MON-3591

Refactor static yaml unmarshaling in CMO

XMLWordPrintable

    • Icon: Epic Epic
    • Resolution: Done
    • Icon: Undefined Undefined
    • openshift-4.15
    • None
    • None
    • None
    • strict yaml unmarshal
    • False
    • None
    • False
    • Not Selected
    • NEW
    • To Do
    • MON-3159Technical Debt
    • NEW
    • 25
    • 25% 25%
    • NA
    • Release Note Not Required
    • 0

      In CMO we have static yaml assets, that are added to our CMO container image and applied by CMO. We read them once from the file system and after that they are chached in memory.

      Currently we use a loose unmarshal, i.e. fields that are spuperflous (not part of the type unmarshaled into) are silently dropped.

      We should use strict unmarshaling in order to catch config mistakes like  https://issues.redhat.com//browse/OCPBUGS-24630.

       

      Additionally we could consider adding the static assets to our CMO binary via golangs embed.

      Discussed, probably not worth it.

            jfajersk@redhat.com Jan Fajerski
            jfajersk@redhat.com Jan Fajerski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: