Uploaded image for project: 'JBoss Modules'
  1. JBoss Modules
  2. MODULES-435

Module.addExportedPaths performance degraded by ModuleIdentifier deprecation

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Unresolved
    • Major
    • 2.1.6.Final
    • 1.12.0.Final
    • None

    Description

      Module.addExportedPaths degrades in performance on 1.6+ after MODULES-256. This could become noticeable in a case of more complex/numerous modules+dependencies and is something I saw remaining for similar cases after resolving WFCORE-6188. It's noteworthy there is no impact on EAP 7.0.9 (around ~10 second start with attached test app) and 7.1.0+ degrades to 30+ seconds with MODULES-256.

      From thread dumps and a JFR, I can see it is spending more times in call stacks like:

      java.lang.String.offsetByCodePoints
org.jboss.modules.ModuleIdentifier.toString()
org.jboss.modules.ModuleLoader.loadModuleLocal
org.jboss.modules.ModuleLoader.preloadModule
org.jboss.modules.Module.addExportedPaths

      And:

      java.lang.String.hashCode
org.jboss.modules.ModuleIdentifier.calculateHashCode
org.modules.ModuleIdentifier.<init>
org.jboss.modules.ModuleIdentifier.fromString
org.jboss.modules.ModuleLoader.preloadModule
org.jboss.modules.Module.addExportedPaths

      For repeating dependencies, these could repeat the same calls a lot for recurring overhead.

      Attachments

        Issue Links

          is caused by

          Sub-task - The sub-task of the issue MODULES-256 Deprecate ModuleIdentifier

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved
          is cloned by

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBEAP-24444 [GSS](7.4.z) MODULES-435 - Module.addExportedPaths performance degraded by ModuleIdentifier deprecation

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          is related to

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) WFCORE-6199 JBoss allows duplicate user and local dependencies

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) WFCORE-6211 Remove ModuleIdentifier from ServiceModuleLoader.preloadModule

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBEAP-24496 [GSS](7.4.z) WFCORE-6211 - Remove ModuleIdentifier from ServiceModuleLoader.preloadModule

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Verified

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) WFCORE-6188 Eliminate useless locking in ServiceModuleLoader

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              Unassigned Unassigned
              rhn-support-aogburn Aaron Ogburn
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: