Uploaded image for project: 'JBoss Modules'
  1. JBoss Modules
  2. MODULES-422

Rework modules version logging

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Unresolved
    • Icon: Major Major
    • 2.2.0.Final
    • None
    • Core

      Copying/pasting relevant discussion on this topic:

      David Lloyd:
      (This is relevant to all library maintainers)
      Over in Quarkus-land, they do not want to log versions at startup,
      however this is a long-standing requirement of EAP,
      so all of our libraries and frameworks log their
      versions at level INFO during static init of any key class

      David Lloyd:
      the proposed solution to the problem is to introduce a system property
      e.g. jboss.log-version, which defaults to true but can be set to false
      to suppress or modify the version log so that it does not log at level INFO

      David Lloyd:
      the Hibernate team is on board with this proposal (as am I) so this covers
      a good % of the libraries in question but I just want to raise it here for
      awareness or to address any concerns

      Brian Stansberry
      OK
      I hate hate hate hate the version logging
      like, i dislike it quite a bit
      an above average amount of dislike
      I understand why some folks want it. Being able to
      turn it off sounds good. If users agree with me they at least can do it.

      Brian Stansberry
      I don't know if people would bother much given how much other stuff we log at boot.
      but otoh if there's a way to have a less verbose log, maybe that will
      motivate going on a bit of a logging diet elsewhere

      Darran Lofthouse
      I think that requirement was needed more in the past when it was fairly common
      for the server's jars to be swapped out with alternate versions so we would
      get a support case in and couldn't work out why all stack traces were off.

      Darran Lofthouse
      Some cases version identification was by comparing the line numbers
      in the trace until we found a version that matched.

      David Lloyd
      nowadays the version is logged in stack traces and can
      be added to the log as well as a format item

      Brian Stansberry
      good point re traces

      Brian Stansberry
      as how we do provisioning it's possible it will get trickier to understand the installed component set just from the log

      David Lloyd
      we could even add a feature to jboss-modules which logs each module & version as it is loaded

      Brian Stansberry
      that might be interesting

      Darran Lofthouse
      +1 handling it at the jboss modules level sounds more reliable,
      we only log a tiny subset of modules loaded by the server at startup

      Brian Stansberry
      that could be done via a specific log category that is easier to control

      Brian Stansberry
      a la what we do with debug stuff at first boot

       

              ropalka Richard Opalka
              ropalka Richard Opalka
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: