Uploaded image for project: 'JBoss Modules'
  1. JBoss Modules
  2. MODULES-395

The ModuleSpec builder does not make honor to the builder API documentation without adding AllPermissions by default

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 1.9.1.Final, 2.0.0.Final
    • Fix Version/s: 1.9.2.Final
    • Component/s: Core
    • Labels:
      None

      Description

      It looks like ModuleSpec does not make honor to the builder API documentation:

      /**
      * Set the permission collection for this module specification.  If none is given, a collection implying
      * {@link AllPermission} is assumed.
      *
      * @param permissionCollection the permission collection
      * @return this builder
      */
      ModuleSpec.Builder setPermissionCollection(PermissionCollection permissionCollection);
      

      My interpretation is if we do not add any PermissionCollection, then AllPermission is assumed. However, when we instantiate a ModuleBuilder the default permission collection is always null, and this ends up creating a ConcreteModuleSpec without permissions.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  yersan Yeray Borges Santana
                  Reporter:
                  yersan Yeray Borges Santana
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: