Uploaded image for project: 'ModeShape'
  1. ModeShape
  2. MODE-2603

Not all times are valid for JcrRepository.determineInitialDelay()

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 5.1.0.Final
    • 5.0.0.Final
    • None
    • None

    Description

      When running ModeShape at various times, I notice that during some hours in the evening (U.S. Eastern time) ModeShape5 will not start up. The issue appears to be coming from the updated logic in this commit:
      https://github.com/ModeShape/modeshape/commit/bc574455aa7e0e7fa6f7a6e4820f5b777bfda3f1#diff-0bfcd93b5cc4efa01e1328b6fcb4c8c4L1987

      ..in JcrRepository.determineInitialDelay().

      For example, with my local system clock set to EDT, running the following build command in the Modeshape codebase (73086b7289270827c2e5d95ddec8fc4107a8a3f1), produces the following results:
      -----cmd
      while true; do echo -n `date` >> compile.out; mvn clean test -s settings.xml -pl modeshape-jcr -Dtest=JcrRepositoryTest | grep "[INFO] BUILD" >> compile.out; sleep 1h; done


      -----results
      Wed May 18 15:21:31 EDT 2016[INFO] BUILD SUCCESS
      Wed May 18 16:22:25 EDT 2016[INFO] BUILD SUCCESS
      Wed May 18 17:23:14 EDT 2016[INFO] BUILD SUCCESS
      Wed May 18 18:24:07 EDT 2016[INFO] BUILD SUCCESS
      Wed May 18 19:25:01 EDT 2016[INFO] BUILD SUCCESS
      Wed May 18 20:25:48 EDT 2016[INFO] BUILD FAILURE
      Wed May 18 21:26:47 EDT 2016[INFO] BUILD FAILURE
      Wed May 18 22:27:35 EDT 2016[INFO] BUILD FAILURE
      Wed May 18 23:28:15 EDT 2016[INFO] BUILD FAILURE
      Thu May 19 00:28:54 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 01:29:41 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 02:30:28 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 03:31:13 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 04:31:58 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 05:32:44 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 06:33:28 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 07:34:15 EDT 2016[INFO] BUILD SUCCESS
      Thu May 19 08:35:01 EDT 2016[INFO] BUILD SUCCESS


      See attached build-error.txt for full build output of one failure run.

      The following pull-request includes a unit test that demonstrates one error and includes a fix.
      https://github.com/ModeShape/modeshape/pull/1561

      Attachments

        Activity

          People

            Unassigned Unassigned
            awoods_jira Andrew Woods (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: