I went through the cppcheck static analysis report on the current mod_proxy_cluster code base, see cppcheck.log, and among many warnings and style check failures, there was a one outstanding error reported, which set me wondering.
The error occurs on two places and I'm scratching my head as to whether is is a false positive or not, WDYT?
- native/mod_manager/domain.c:198: (error) Address of local auto-variable assigned to a function parameter.
- native/mod_manager/node.c:227: (error) Address of local auto-variable assigned to a function parameter.
Is it O.K. to handle local, function scope, automatically allocated variable this way? To use it's address later in ap_slotmem_do? Couldn't it trigger undefined behaviour and cause some of our rare, hard to reproduce crashes?
Feel free to pick up any other pertinent messages from the log.