Uploaded image for project: 'Managed Service - Streams'
  1. Managed Service - Streams
  2. MGDSTRM-8179

Create/Update integration test for the ManagedKafka.Spec.Oauth. *

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None
    • 5
    • False
    • Hide

      None

      Show
      None
    • False
    • Yes
    • ---
    • ---

      WHAT

      Create/Update integration test for the ManagedKafka.Spec.Oauth.*

      Note: This can be done post migration to sso.redhat.com so that custom claim checks are subject to change.

      WHY

      The tests are missing or existing test cases need to be updated to verify the oauth spec fields check in the Kafka CR

      HOW

      Add them here: https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/2c19e350d9b8e70ead439167ce69ad1b86f69886/internal/kafka/test/integration/data_plane_endpoints_test.go

      They are similar to:

       if mk := findManagedKafkaByID(list.Items, testKafka.ID); mk != nil { 
              
      
              
                 	// check canary service account 
              
      
              
                 	Expect(mk.Spec.ServiceAccounts).To(HaveLen(1)) 
              
      
              
                 	canaryServiceAccount := mk.Spec.ServiceAccounts[0] 
              
      
              
                 	Expect(canaryServiceAccount.Name).To(Equal("canary")) 
              
      
              
                 	Expect(canaryServiceAccount.Principal).To(Equal(canaryServiceAccountClientId)) 
              
      
              
                 	Expect(canaryServiceAccount.Password).To(Equal(canaryServiceAccountClientSecret)) 
              
      
              
                 } else { 

      DONE

      • Integration tests are create and updated
      • Code reviewed
      • Tests run successfully

       

              Unassigned Unassigned
              rarangan_rhmi Rajagopalan Ranganathan
              MK - Control Plane
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: