-
Task
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
-
MK - Sprint 218
WHAT
Increase unit test code coverage in pkg/shared where possible or ignore files, for which writing unit tests is not feasible in the make test make target
To see which lines aren't covered in files in the pkg/shared directory run:
make test make test/html/coverage/report
Then select each of the files in the pkg/shared folder. Write new or extend existing tests to increase the coverage
IMPORTANT
Try to reuse code that exists in test/mocks/api_server.go or write object creation functions in the test/mocks/ or internal/kafka/test/mocks (if the test is in the internal package) instead of creating test objects in the individual test files. If objects required for testing aren't created in the test/mocks/api_server.go, feel free to create new file that will include reusable test stuff related to your tests
WHY
<Why is this task being done?>
HOW
<Suggestions for how this may be solved.> [Optional]
DONE
Include the following where applicable:
- <bulleted list of functional acceptance criteria that need to be completed>
- <call out anything on the documentation side that's needed as a result of this task being completed>
- <any metrics, monitoring dashboards and alerts that need to be created or be updated>
- <SOP creation or updates>
Guidelines
The following steps should be adhered to:
- Required tests should be put in place - unit, integration, manual test cases (if necessary)
- CI and all relevant tests passing
- Changes have been verified by one additional reviewer against:
- each required environment
- each supported upgrade path
- If the changes could have an impact on the clients (either UI or CLI), a JIRA should be created for making the required changes on the client side and acknowledged by one of the client side team members. PR has been merged