Uploaded image for project: 'Managed Service - Streams'
  1. Managed Service - Streams
  2. MGDSTRM-10907

Performance Test results recorded against the wrong commit

XMLWordPrintable

    • False
    • None
    • False
    • No
    • ---
    • ---

      *Describe the bug*
      I triggered a performance test action against a dependabot branch. The [action completed successfully](https://github.com/kroxylicious/kroxylicious/actions/runs/4370692241), and checked out the correct branch. However in [the commit](https://github.com/kroxylicious/kroxylicious/commit/a5832b37cfb914bfb0434862e14b7eb2c96f26d8) pushed to the performance-results branch all the details are about the head commit on `main`.

      *To Reproduce*
      1. Trigger a performance test using a comment on a PR (the PR must be from a branch in kroxylicious/kroxylicious) with a head commit different from the head commit on main
      2. View the results pushed to the `performance-results`
      3. The latest results should reference the head commit on `main` rather than the head commit on the PR branch.

      *Expected behavior*
      Performance test results record the commit id, message, author, timestamp for the commit that was performance tested

      *Additional Context*
      I think the problem is that the benchmark action is run in a context that knows the workflow is running from `main` and so that's what it uses when detecting the commit to inject into the results.

      I've created an [issue](https://github.com/benchmark-action/github-action-benchmark/issues/157) in the benchmark-actions repo to see if they like the idea of integrating with `issue_comment` events directly or adding parameters so we could pass a ref, owner and repository to the action so it could use that to load the data.

              fvila@redhat.com Francisco Vila
              keithbwall Keith Wall
              Kafka Integrations
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: