-
Bug
-
Resolution: Unresolved
-
Normal
-
None
-
None
-
None
-
3
-
False
-
None
-
False
-
No
-
---
-
---
-
-
WHAT
The deploy/secrets make target fails to execute on MacOS due to invalid base64 parameter '-w'.
The base64 binary for MacOS doesn't have the -w0 parameter, the equivalent parameter is -b0.
WHY
This make target is used for deploying KFM on OpenShift so we need to ensure this works on all platforms for anyone wanting to run through this process.
HOW
Update the deploy/secrets make target so that the base64 parameters changes based on the OS used.
If the OS is darwin, it should use base64 -b0.
If the OS is linux, it should use base64 -w0.
See https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/pull/1602#issuecomment-1448066041 as an example on how to do this.
DONE
- make deploy/secrets executes successfully on Linux
- make deploy/secrets executes successfully on MacOS
Guidelines
The following steps should be adhered to:
- Required tests should be put in place - unit, integration, manual test cases (if necessary)
- CI and all relevant tests passing
- Changes have been verified by one additional reviewer against:
- each required environment
- each supported upgrade path
- If the changes could have an impact on the clients (either UI or CLI), a JIRA should be created for making the required changes on the client side and acknowledged by one of the client side team members. PR has been merged