Uploaded image for project: 'Managed Service - API'
  1. Managed Service - API
  2. MGDAPI-6131

RHOAM operator not picking up pagerduty secret if created too late

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 1.40.0
    • 1.38.0
    • None
    • None
    • RHOAM Sprint 52

      WHY
      RHOAM installation might get stuck in Preflight due to "Could not find redhat-rhoam-pagerduty secret in redhat-rhoam-operator namespace" even if the pagerduty secret is actually present in the namespace.

      WHAT
      Improve the logic so that the RHOAM operator won't get stuck if pagerduty secret is not present and is only created later.

      HOW
      I am not 100% sure but from a quick look it seems that non-empty result with Requeue: true should be returned in these two occassions:
      https://github.com/integr8ly/integreatly-operator/blob/master/controllers/rhmi/rhmi_controller.go#L795-L798

      The result instance is already created and can be used potentially:
      https://github.com/integr8ly/integreatly-operator/blob/master/controllers/rhmi/rhmi_controller.go#L739-L742

      Similar PR for better insight & inspiration:
      https://github.com/integr8ly/integreatly-operator/pull/3297/files

      TESTS
      N/A

      DONE

      • RHOAM operator detects the pagerduty secret and proceeds even if this secret is created minutes after the first reconcile

              trepel Tomas Repel
              trepel Tomas Repel
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: