Uploaded image for project: 'Managed Service - API'
  1. Managed Service - API
  2. MGDAPI-6050

ClusterObjectTemplate custom resources are not labeled consistently

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 1.39.0
    • None
    • None
    • RHOAM Sprint 48

      WHY
      To have the ClusterObjectTemplate (COT) resources labeled as needed.

      WHAT
      There are various COT custom resources created as part of RHOAM installation. These are provided by package operator and not via rhoam operator directly. We need to have these properly labeled. This needs to be so for both addon flow installation and installation from master (cluster/prepare/local & cluster/deploy make targets).

      HOW
      The thing is that the test searches for COTs having "package-operator.run/package=managed-api-service" label. However, all the COTs on cluster have different labels ( "package-operator.run/instance=managed-api-service" and "package-operator.run/package=rhoam-observability" labels) with the single exception of COT called "managed-api-service" which has no label at all. The fix would be to update the label here: https://github.com/integr8ly/integreatly-operator/blob/master/pkg/products/obo/clusterPackage.go#L42 it's unclear wheter that's the right fix.

      Michal's suggestion after very quick investigation:
      I think what we should do is change this https://github.com/integr8ly/integreatly-operator/blob/master/config/hive-config/package.yaml#L4 to what's in here: https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/blob/main/addons/rhoams/package/manifest.yaml#L4

      TESTS
      This should pass both installation types:
      INSTALLATION_TYPE=managed-api DESTRUCTIVE=false LOCAL=false TEST="Verify ClusterObjectTemplates ready state" make test/e2e/single

      DONE

      • the test passes for both ways of RHOAM installation

            ckyrillo@redhat.com Carl Kyrillos
            trepel Tomas Repel
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: