Uploaded image for project: 'Managed Service - API'
  1. Managed Service - API
  2. MGDAPI-4814

Race condition setting CRO network strategy

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • 1.28.0
    • 1.27.0, 1.28.0
    • None
    • RHOAM Sprint 31, RHOAM Sprint 32

      WHAT
      There is a race condition in RHOAM addon install where the CRO network strategy might not be updated until after the installation has already began. We saw this in the pipeline run here.

      In the RHOAM CRO product reconciler we set the CIDR value from the addon parameter in the strategy if it exists, but move on if it does not.

      We then create the CRO subscription and createOrUpdate the strategy map after the subscription is created.

      Only on the next reconcile of the CRO product in RHOAM will the strategy be updated with the CIDR value from the addon parameter.

      If CRO manages to install and start to provision one of the Postgres/Redis resources before the reconcile updates the strategy, it will provision the VPC at the default available CIDR range instead of using the one in the addon parameter.

      HOW

      • Move the CIDR block update to after the create / update of the strategy map
      • Ensure that if the addon parameter CIDR range is set, that we do not create the CRO subscription until the strategy is present with the CIDR range set

      TESTS
      <List of related tests>

      DONE

              vmogilev_rhmi Valery Mogilevsky
              acatterm@redhat.com Adam Cattermole
              Adam Cattermole Adam Cattermole
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: