Uploaded image for project: 'Managed Service - API'
  1. Managed Service - API
  2. MGDAPI-4729

Add tags to replication group in CRO (fix e2e F03)

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Critical Critical
    • 1.38.0
    • None
    • None
    • RHOAM Sprint 42, RHOAM Sprint 43, RHOAM Sprint 44

      WHAT
      Test F03 is failing as it was written with STS in mind but not tested on non-STS.

      Make CRO add tags to replication groups for non-sts clusters.

      STS clusters tag the elasticache resources on creation, but non-STS tag the nodes only.

      See here: https://github.com/integr8ly/cloud-resource-operator/blob/master/pkg/providers/aws/provider_redis.go#L349

      HOW
      Add tags to replication group - see AddTagsToResource function used in TagElasticacheNode

      It might be possible to change the code to only tag the replication group, and not have to tag the nodes as the docs state that: "Tags will be added/removed from the replication group and the action will be propagated to all clusters in the replication group."

      https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Tagging-Resources.html

      TESTS
      <List of related tests>

      DONE
      Elasticache replication groups have tags for non-STS clusters
       
      F03 passes for a non-STS cluster

              dmoskale@redhat.com Denis Moskalenko
              acatterm@redhat.com Adam Cattermole
              Austin Cunningham Austin Cunningham
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: