Uploaded image for project: 'must-gather'
  1. must-gather
  2. MG-91

Adhere MustGather CR to openshift/api best practices

XMLWordPrintable

    • Icon: Spike Spike
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False

      As of tech preview release, the MustGather CR: https://github.com/openshift/must-gather-operator/blob/master/api/v1alpha1/mustgather_types.go in the operator lacks consistency with other API field related nuances which are used in openshift/api repo as a standard.

      For eg. Audit bool would be better of as *bool, MustGatherTimeout metav1.Duration would be better of as *metav1.Duration, etc.

      ref: https://github.com/search?q=repo%3Aopenshift%2Fapi%20*bool&type=code

       

      Acceptance criteria: analyze the pitfalls present today and have an improvement plan before operator GA to adhere with k8s and OpenShift API best practices for CRs shipped with must-gather-operator.

              Unassigned Unassigned
              swghosh@redhat.com Swarup Ghosh
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: