-
Story
-
Resolution: Duplicate
-
Undefined
-
None
-
None
-
None
Background
As part of https://github.com/openshift/machine-config-operator/pull/3270, Joel moved us to ConfigMapsLeases for our lease because the old way of using ConfigMaps was being deprecated in favor of the "Leases" resource.
ConfigMapsLeases were meant to be the first phase of the migration, eventually ending up on LeasesResourceLock,so at some point we need to finish.
Since we've already had ConfigMapsLeases for at least a release, we should now be able to complete the migration by changing the type of resource lock here https://github.com/openshift/machine-config-operator/blob/4f48e1737ffc01b3eb991f22154fc3696da53737/cmd/common/helpers.go#L43 to LeasesResourceLock
We should probably also clean up after ourselves so nobody has to open something like https://bugzilla.redhat.com/show_bug.cgi?id=1975545 again
(Yes this really should be as easy as it looks, but someone needs to pay attention to make sure something weird doesn't happen when we do it)
Some supporting information is here, if curious:
https://github.com/kubernetes/kubernetes/pull/106852
https://github.com/kubernetes/kubernetes/issues/80289
Goal
Finish lease lock type migration by changing lease lock type to LeaseResourceLock
Done When
- MCO is no longer using ConfigMapsLeases
- MCO cleans up old ConfigMaps that were being used as leases?
- No weird/unexplainable timings/errors are introduced
- Tests pass
- clones
-
MCO-532 Finish lease type migration
- Closed