While experimenting with enabling Shellcheck on templatized scripts (see: https://github.com/openshift/machine-config-operator/pull/3380), I ran into an issue wherein the OpenShift CI system did not recognize that I added shellcheck to the Dockerfile.

As it turns out, this is because our current buildroot configuration for OpenShift CI is incorrect. What I think we need is a project_image configuration similar to what is shown here: https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image

Done When:

• We have a separate Dockerfile.buildroot in the MCO repository that has all of our intermediate tooling / test dependencies contained therein, such as shellcheck, setup-envtest (possibly with the most current kubebuilder toolset), golangci-lint, etc.
• We have configuration checked into the openshift/release repository that builds our project image and we can use the baked-in tools / test dependencies in all of the test stages, as needed.