-
Story
-
Resolution: Unresolved
-
Normal
-
None
-
None
The `GetDegradedMachines` function in /controller/common/helpers.go was originally introduced in the MCO as `getDegradedMachines` in /pkg/controller/node/status.go as part of o/machine-config-operator#597 over six years ago. Some conditions in the function, such as the desired config annotation empty check have not changed since the original implementation.
As noted in a recent review from Jerry on o/machine-config-operator#5141, we might want to revisit the machine count checks to ensure they still make sense with the current operations of the MCO. This scope of functions to review and update are up to the team member that takes on this work, but should be clearly noted in comments on this card.
Done when:
- Legacy machine count functions have been evaluated and updated as needed
- The scope of functions evaluated is clearly documented on this card.