Uploaded image for project: 'Machine Config Operator'
  1. Machine Config Operator
  2. MCO-1092

Adapt the MCO's featuregate usage to new API

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • False
    • None
    • False
    • MCO Sprint 251
    • 0

            [MCO-1092] Adapt the MCO's featuregate usage to new API

            Dalia Khater added a comment -

            this work was completed, then reverted. a new PR was opened to investigate the payload tests. https://github.com/openshift/machine-config-operator/pull/4306

            Dalia Khater added a comment - this work was completed, then reverted. a new PR was opened to investigate the payload tests. https://github.com/openshift/machine-config-operator/pull/4306

            Dalia Khater added a comment -

            after trying to find the issue why so many watches were introduced, we are going to do payload testing to see if we can pinpoint the issue

            Dalia Khater added a comment - after trying to find the issue why so many watches were introduced, we are going to do payload testing to see if we can pinpoint the issue

            Stephen Benjamin added a comment -

            Apologies but TRT has had to revert the PR.

            Revert

            https://github.com/openshift/machine-config-operator/pull/4295

             

            Slack thread

            https://redhat-internal.slack.com/archives/C01CQA76KMX/p1711731918002519?thread_ts=1711711538.689689&cid=C01CQA76KMX

             

            Stephen Benjamin added a comment - Apologies but TRT has had to revert the PR. Revert https://github.com/openshift/machine-config-operator/pull/4295   Slack thread https://redhat-internal.slack.com/archives/C01CQA76KMX/p1711731918002519?thread_ts=1711711538.689689&cid=C01CQA76KMX  

            Rio Liu added a comment -

            pre-merge-tested https://github.com/openshift/machine-config-operator/pull/4275#issuecomment-2022439277

             

            Rio Liu added a comment - pre-merge-tested https://github.com/openshift/machine-config-operator/pull/4275#issuecomment-2022439277  

            Dalia Khater added a comment -

            CRDs required for envtest to emulate a fake environment (by loading all the manifests that would be present for bootstrapping was moved, causing bootstrap failure. by including the manifests in bootstrap, we got ci passing again
             

            Dalia Khater added a comment - CRDs required for envtest to emulate a fake environment (by loading all the manifests that would be present for bootstrapping was moved, causing bootstrap failure. by including the manifests in bootstrap, we got ci passing again  

            Dalia Khater added a comment -

            see https://issues.redhat.com/browse/MCO-817 for comments related to this story. this work has been combined with 817.

            current updates: fixed bootstrap test to construct a featureset map from the current enabled and disabled feature gates. waiting for CI

            Dalia Khater added a comment - see https://issues.redhat.com/browse/MCO-817 for comments related to this story. this work has been combined with 817. current updates: fixed bootstrap test to construct a featureset map from the current enabled and disabled feature gates. waiting for CI

            Dalia Khater added a comment -

            https://github.com/openshift/machine-config-operator/pull/4275

            Dalia Khater added a comment - https://github.com/openshift/machine-config-operator/pull/4275

              dkhater@redhat.com Dalia Khater
              jerzhang@redhat.com Yu Qi Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: