Uploaded image for project: 'Machine Config Operator'
  1. Machine Config Operator
  2. MCO-1016

Remove logs about non-existent changes in the machine-config-controller

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • MCO Sprint 249, MCO Sprint 250, MCO Sprint 263 (DevEx), MCO Sprint 271, MCO Sprint 272, MCO Sprint 273, MCO Sprint 274, MCO Sprint 275, MCO Sprint 277, MCO Sprint 278
    • 0

      There is issue raised and solved in patch: https://github.com/openshift/machine-config-operator/pull/536 about removing circular logs about non-existence updates to the kubelet config. However, kubelet config is not the only place that is generating inaccurate logs. As a result, there seems to be the need to bring in the mechanism for removing logs about non-existent changes across the machine-config-controller. After going through the updatFunc of the subcontrollers, it is concluded that:

      (1) The following updateFunc has already adapted a mechanism to identify real updates:

      • updateContainerRuntimeConfig
      • updateKubeletConfig
      • updateFeature
      • updateNodeConfig 
      • checkMaterNodesOnUpdate 

      (2) The following updateFunc has NOT adapted a mechanism to identify real updates and are currently generating circular inaccurate logs 

      • updateMachineSet - covered by djoshy 
      • updateConfigMap - covered by djoshy 
      • updateControllerConfig 
      • updateMachineConfig - template 
      • updateMachineConfig - render 
      • updateSecret

      Need to do:

      Go through the updateFuncs that currently are not able to identify real updates and adapt a mechanism to enable that.

      Done when:

      Only real updates are reported. All logs about non-existent changes are effectively removed. 

              umohnani Urvashi Mohnani
              rh-ee-iqian Ines Qian
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: