Uploaded image for project: 'Maistra'
  1. Maistra
  2. MAISTRA-2379

luajit patches for Z/P do not apply

    XMLWordPrintable

Details

    • Task
    • Resolution: Duplicate
    • Major
    • None
    • None
    • proxy
    • None
    • False
    • False
    • Undefined

    Description

      We have patches for Z/P for proxy here: https://github.com/maistra/proxy/tree/maistra-2.1/maistra/patches

      They are applied as part of the script that updates dependencies: https://github.com/maistra/proxy/blob/1a5d9cbaaeb91d69d811bcb3891fb93f135e44f8/maistra/scripts/update-deps.sh#L101-L102

       

      However, they no longer apply cleanly, likely after this was merged: https://github.com/maistra/envoy/pull/75

       

      For now we disabled them so that it doesn't block our script to work (the patch failing to apply stops the script).

      We should evaluate if they are still needed and update them if the answer to this question is yes.

       

      Related question: Why not having (if they aren't yet) those patches submitted upstream directly?

      Attachments

        Issue Links

          Activity

            People

              jsantana@redhat.com Jonh Wendell
              jsantana@redhat.com Jonh Wendell
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: