Uploaded image for project: 'OpenShift Logging'
  1. OpenShift Logging
  2. LOG-6352

Infinite validation messages for pipelines

XMLWordPrintable

    • False
    • None
    • False
    • NEW
    • NEW
    • Before this update, an infinite loop in pipeline validation could occur if one name was a substring of another. This update introduces stricter name equality checks to resolve the infinite loop issue.
    • Bug Fix
    • Log Collection - Sprint 262, Log Collection - Sprint 263

      Description of problem:

      ClusterLogForwarder object status keep adding duplicate messages to pipelineConditions like

          - lastTransitionTime: '2024-11-06T05:27:43Z'
      message: pipeline "abc-app-logs" is valid
      reason: ValidationSuccess
      status: 'True'
      type: observability.openshift.io/ValidPipeline-abc-app-logs

      Version-Release number of selected component (if applicable):

      6.0.1

      How reproducible:

      Steps to Reproduce:

      1. apply a ClusterLogForwarder with 2 pipelines, one name is the substring of the other
      apiVersion: observability.openshift.io/v1
kind: ClusterLogForwarder
metadata:
  name: collector
spec:
  filters:
  - name: detectexception
    type: detectMultilineException
  managementState: Managed
  outputs:
  - cloudwatch:
      authentication:
        awsAccessKey:
          keyId:
            key: aws_access_key_id
            secretName: cloudwatch-access
          keySecret:
            key: aws_secret_access_key
            secretName: cloudwatch-access
        type: awsAccessKey
      groupName: cluster.{.kubernetes.namespace_name||"unknown"}
      region: us-east-1
    name: cloudwatch
    type: cloudwatch
  pipelines:
  - inputRefs:
    - application
    name: app-logs
    outputRefs:
      - cloudwatch
  - filterRefs:
    - detectexception
    inputRefs:
    - application
    name: abc-app-logs
    outputRefs:
    - cloudwatch
  serviceAccount:
    name: cluster-log-forwarder

      Actual results:

      duplicate messages about `pipeline "abc-app-logs" is valid` is being created until object size exceed k8s limit, and the overall validation status is False

      Expected results:

      validate success and collector pods can start

      Additional info:

      if change names to not contains each other, like one `app-logs`, the other one `abc-logs`, then validation can pass as expected

              vparfono Vitalii Parfonov
              rh-ee-dwan Di Wang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: