Uploaded image for project: 'OpenShift Logging'
  1. OpenShift Logging
  2. LOG-5864

Unconsumed filter definitions should show validation warnings when spec.pipelines.filterRefs is missing

XMLWordPrintable

    • False
    • None
    • False
    • NEW
    • OBSDA-550 - Updated APIs for Logging 6.0
    • NEW
    • Release Note Not Required

      Description
      When spec.filters is defined on the CLF but spec.pipelines.filterRefs are missing, CLF does not show any warnings. Since filters will not be applied in this case and CLF status shows all filters are valid, one can assume that filters are applied correctly. It's better to show validation warnings/messages under CLF status.

      How reproducible: Always

      Steps to reproduce:
      1) Deploy CLO v6.0
      2) Create CLF with spec.filters but do not define spec.pipelines.filterRefs
      3) Check CLF status

      Expected Result: CLF status shows filterRefs are missing validations warnings.

      Actual Result: All filters are valid and no warnings are shown.

      CLF:

      Below spec.filters is defined but spec.pipelines.filterRefs is missing but status shows pipelines and filters are valid.

      apiVersion: observability.openshift.io/v1
      kind: ClusterLogForwarder
      metadata:
        creationTimestamp: '2024-07-22T13:46:31Z'
        generation: 1
        labels:
          app.kubernetes.io/component: collector
          app.kubernetes.io/instance: log-collector
          app.kubernetes.io/managed-by: cluster-logging-operator
          app.kubernetes.io/name: vector
          app.kubernetes.io/part-of: cluster-logging
        name: my-clf-instance
        namespace: my-clf-ns
      spec:
        filters:
          - name: enable-json-parse
            type: parse
        inputs:
          - application:
              excludes:
                - namespace: exclude-app
            name: my-app-logs
            type: application
        managementState: Managed
        outputs:
          - googleCloudLogging:
              authentication:
                credentials:
                  key: google-application-credentials.json
                  secretName: gcp-secret
              id:
                type: project
                value: openshift-qe
              logId: kbharti-parse-json
            name: gcp-logs
            type: googleCloudLogging
        pipelines:
          - inputRefs:
              - my-app-logs
            name: my-outputs
            outputRefs:
              - gcp-logs
        serviceAccount:
          name: my-clf-gcp-sa
      status:
        conditions:
          - lastTransitionTime: '2024-07-22T13:46:31Z'
            message: 'permitted to collect log types: [application]'
            reason: ClusterRolesExist
            status: 'True'
            type: observability.openshift.io/Authorized
          - lastTransitionTime: '2024-07-22T13:46:31Z'
            message: ''
            reason: ValidationSuccess
            status: 'True'
            type: observability.openshift.io/Valid
          - lastTransitionTime: '2024-07-22T13:46:36Z'
            message: ''
            reason: ReconciliationComplete
            status: 'True'
            type: Ready
        filtersStatus:
          - lastTransitionTime: '2024-07-22T13:46:31Z'
            message: filter valid
            reason: ValidationSuccess
            status: 'True'
            type: observability.openshift.io/ValidFilter-enable-json-parse
        inputsStatus:
          - lastTransitionTime: '2024-07-22T16:16:38Z'
            message: input "my-app-logs" is valid
            reason: ValidationSuccess
            status: 'True'
            type: observability.openshift.io/ValidInput-my-app-logs
        outputsStatus:
          - lastTransitionTime: '2024-07-22T13:46:31Z'
            message: output "gcp-logs" is valid
            reason: ValidationSuccess
            status: 'True'
            type: observability.openshift.io/ValidOutput-gcp-logs
        pipelinesStatus:
          - lastTransitionTime: '2024-07-22T13:46:31Z'
            message: pipeline valid
            reason: ValidationSuccess
            status: 'True'
            type: observability.openshift.io/ValidPipeline-my-outputs

              Unassigned Unassigned
              rhn-support-kbharti Kabir Bharti
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: