Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Done
Priority: Major
Fix Version/s: Logging 5.7.3
Affects Version/s: Logging 5.7.0
Component/s: Log Collection
Labels:
- devel_ack+

Blocked:
False
Blocked Reason:
None
Ready:
False
Docs QE Status:
NEW
QE Status:
VERIFIED
Release Note Text:

Hide
Before this change ClusterLogForwarder loki outputs with label keys that included slashes would cause the collector to crashloop. This corrects that behavior to properly replace slashes with underscores so the collector can start and properly set the loki label

Show
Before this change ClusterLogForwarder loki outputs with label keys that included slashes would cause the collector to crashloop. This corrects that behavior to properly replace slashes with underscores so the collector can start and properly set the loki label
Release Note Type:
Bug Fix

Sprint:
Log Collection - Sprint 237, Log Collection - Sprint 238
Severity:
Moderate

SFDC Cases Links:
SFDC Cases Counter:

Description

Description of problem:

Related to #1790 which enabled labelKeys with `.` and `/`. This feature is now broken in 5.7 (I haven't checked 5.6)

Given this log forwader:

apiVersion: logging.openshift.io/v1
kind: ClusterLogForwarder
metadata:
  name: instance
  namespace: openshift-logging
spec:
  outputs:
   - name: central-loki 
     type: "loki" 
     url: ...
     secret:
       name: central-loki
     loki:
      labelKeys:
        - log_type
        - kubernetes.namespace_name
        - kubernetes.pod_name
        - kubernetes.host
        - kubernetes.container_name
        - tag
        - kubernetes.labels.application
        - kubernetes.labels.foo/bar
  pipelines:
   - name: all-logs
     detectMultilineErrors: true
     inputRefs:
      - application
     outputRefs:
      - central-loki

The resulting configmap for the collector has this line:

[sinks.central_loki.labels]
kubernetes_container_name = "{{kubernetes.container_name}}"
kubernetes_host = "${VECTOR_SELF_NODE_NAME}"
kubernetes_labels_application = "{{kubernetes.labels.application}}"
# the following line breaks the collector
kubernetes_labels_foo/bar = "{{kubernetes.labels.foo/bar}}" 
kubernetes_namespace_name = "{{kubernetes.namespace_name}}"
kubernetes_pod_name = "{{kubernetes.pod_name}}"
log_type = "{{log_type}}"
tag = "{{tag}}"

*Environment*