-
Enhancement
-
Resolution: Done
-
Blocker
-
0.5.0
-
None
-
OpenShift 4.2
-
2019 Week 44-46 (from Okt 28), 2019 Week 47-49 (from Nov 18)
When setting a default limit to buildConfigs, OpenShift will also set default limits for every container that will start for s2i.
In cases likes this, if a cluster administrator set a quota bellow the default limit set by OpenShift, the build won't start:
Error creating build pod: Pod "spring-todo-3-build" is invalid: [spec.containers[0].resources.requests: Invalid value: "1": must be less than or equal to cpu limit, spec.containers[0].resources.requests: Invalid value: "2Gi": must be less than or equal to memory limit, spec.initContainers[0].resources.requests: Invalid value: "1": must be less than or equal to cpu limit, spec.initContainers[0].resources.requests: Invalid value: "2Gi": must be less than or equal to memory limit, spec.initContainers[1].resources.requests: Invalid value: "1": must be less than or equal to cpu limit, spec.initContainers[1].resources.requests: Invalid value: "2Gi": must be less than or equal to memory limit]
We shouldn't define a default limit in the Operator any more to avoid scenarios like this.
An user should set their default limit if needed.
