-
Bug
-
Resolution: Done
-
Major
-
None
-
None
-
None
-
False
-
False
-
Undefined
-
First compile https://github.com/manstis/pmml-codegen
Then compile https://github.com/manstis/marshaller/tree/embedded-model
If you run marshaller-jre/Main.java it works OK.
If you uncomment the following and run you'll see the generated (un)marshallers fail.
Interestingly
there are also some (un)marshallers missing too (e.g. com.anstis.pmml.model.impl.4_v.AttributeBeanXMLDeserializerImpl - the example above in the JIRA description was a little contrived).IDK whether this is because others fail to compile.
First compile https://github.com/manstis/pmml-codegen Then compile https://github.com/manstis/marshaller/tree/embedded-model If you run marshaller-jre/Main.java it works OK. If you uncomment the following and run you'll see the generated (un)marshallers fail. https://github.com/manstis/marshaller/commit/72e84ee9e941cc97c69e909bcaae9b8e5fd3033c#diff-6cf38ea985a013530cc1f35e422e035e956f7046291a1c5328f1086eeb9bb75fR25-R29 https://github.com/manstis/marshaller/commit/72e84ee9e941cc97c69e909bcaae9b8e5fd3033c#diff-6cf38ea985a013530cc1f35e422e035e956f7046291a1c5328f1086eeb9bb75fR36-R40 https://github.com/manstis/marshaller/commit/72e84ee9e941cc97c69e909bcaae9b8e5fd3033c#diff-6cf38ea985a013530cc1f35e422e035e956f7046291a1c5328f1086eeb9bb75fR49-R73 https://github.com/manstis/marshaller/commit/72e84ee9e941cc97c69e909bcaae9b8e5fd3033c#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R144-R145 Interestingly there are also some (un)marshallers missing too (e.g. com.anstis.pmml.model.impl.4_v.AttributeBeanXMLDeserializerImpl - the example above in the JIRA description was a little contrived). IDK whether this is because others fail to compile. -
I have split the POJOs generation into two phases:-
- Generate interfaces only
- Generate classes that implement the interfaces
This will support the UI working against the interfaces but different (un)marshallers for different versions of the concrete classes generated for different versions of the domain (DMN, PMML, BPMN etc) model.
For example:-
I generate this using JAXB:-
@XmlAccessorType(XmlAccessType.FIELD)
@XmlType(name = "", propOrder = {
"extension",
"attribute"
})
@XmlRootElement(name = "Characteristic")
@JsType
@GWT3Export
public class Characteristic
implements com.anstis.pmml.model.api.Characteristic
{
@XmlElement(name = "Extension", type = Extension.class)
protected List<com.anstis.pmml.model.api.Extension> extension;
@XmlElement(name = "Attribute", required = true, type = Attribute.class)
protected List<com.anstis.pmml.model.api.Attribute> attribute;
...
The class Characteristic implements the interface ...api.Characteristic.
The mapper-xml code generation is trying to use (un)marshallers based on the field (i.e. the underlying interface, com.anstis.pmml.model.api.AttributeBeanXMLDeserializerImpl) and not the @XmlElement[Ref]'s type, com.anstis.pmml.model.impl.v4_4.AttributeBeanXMLDeserializerImpl.
JRE's JAXB Reference Implementation (un)marshalls correctly based on @XmlElement[Ref]'s types.
- blocks
-
FAI-487 Score Cards: Refactor (un)marshaller
-
- Backlog
-
- is related to
-
-
- Resolved
-