Uploaded image for project: 'Kogito'
  1. Kogito
  2. KOGITO-550

In certain conditions, operator will swallow expcetions

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 0.6.0
    • 0.5.0
    • Operator
    • None
    • 2019 Week 44-46 (from Okt 28)

      During the reconcile loop, we should exit the loop once we face an error and update the status accordingly. Take this for example:

              if err != nil {
      		updateResourceResult.Err = err
      		updateResourceResult.ErrorReason = v1alpha1.ParseCRRequestFailedReason
      	}
      
      	deployedRes, err := kogitores.GetDeployedResources(instance, r.client)
      	if err != nil {
      		updateResourceResult.Err = err
      		updateResourceResult.ErrorReason = v1alpha1.RetrieveDeployedResourceFailedReason
      	}
      

      The controller should update the status with the error and exit the loop, not continue to not swallow any possible errors.

              xiezhang@redhat.com Xieshen Zhang
              rhn-support-zanini Ricardo Zanini
              Tristan Radisson Tristan Radisson (Inactive)
              Tristan Radisson Tristan Radisson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: