-
Task
-
Resolution: Done
-
Major
-
None
-
1.5.0.Final
-
None
-
False
-
False
-
Undefined
-
-
2021 Week 10-12 (from Mar 8)
Following review comments of https://github.com/kiegroup/kogito-operator/pull/790 need to be incorporated
- Rename KogitoInfra condition type : https://github.com/kiegroup/kogito-operator/pull/790#discussion_r596027395
- lastTransitionTime should change only when transition in condition : https://github.com/kiegroup/kogito-operator/pull/790#discussion_r596658564
- KogitoBuild condition reason should be meaningful :https://github.com/kiegroup/kogito-operator/pull/790#issuecomment-801760915
As discussed with ksuta, conditions should be like following :
KogitoBuild | ||||
Condition | Failed | Running | Successful | Reason |
On Err | ✔ | ✘ | ✘ | Error reason |
Build not started | - | ✔ | ✘ | Build Not started, Build Not started |
Build- Failed, Cancelled | ✔ | ✘ | ✘ | Build failed, Build failed, Build failed |
Build- New, Pending, Running | - | ✔ | ✘ | Build running, Build running, Build running |
Build – Complete | - | ✘ | ✔ | Build complete, Build complete |
KogitoInfra | ||||
Condition | Configured | Reason | ||
On Err | ✘ | Error reason | ||
No Err | ✔ | Configured successfully | ||
- relates to
-
KOGITO-4469 Conditions should reflect latest evaluated status
- Resolved