Uploaded image for project: 'Kogito'
  1. Kogito
  2. KOGITO-313

Validate if process id can be used for generated class names to improve error handling

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 0.5.0
    • 0.3.0, 0.4.0
    • Core Engine
    • None
    • 2019 Week 38-40 (from Sep 16)

      In case process id that is set on BPMN process definition can't be used as class name there is meaningless exception thrown at build time

      13:25:29,748 ERROR [io.qua.dev.DevModeMain] Failed to start quarkus: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
      	[error]: Build step io.quarkus.kogito.deployment.KogitoAssetsProcessor#generateModel threw an exception: com.github.javaparser.ParseProblemException: Encountered unexpected token: "-" "-"
          at line 1, column 27.
      
      Was expecting:
      
          <EOF>
      
      Problem stacktrace :
        com.github.javaparser.GeneratedJavaParser.generateParseException(GeneratedJavaParser.java:10567)
        com.github.javaparser.GeneratedJavaParser.jj_consume_token(GeneratedJavaParser.java:10426)
        com.github.javaparser.GeneratedJavaParser.ResultTypeParseStart(GeneratedJavaParser.java:5785)
        com.github.javaparser.JavaParser.parse(JavaParser.java:115)
        com.github.javaparser.JavaParser.parseType(JavaParser.java:404)
        com.github.javaparser.StaticJavaParser.parseType(StaticJavaParser.java:341)
        com.github.javaparser.ast.nodeTypes.NodeWithType.setType(NodeWithType.java:72)
        org.kie.kogito.codegen.process.ProcessesContainerGenerator.addProcessFactoryMethod(ProcessesContainerGenerator.java:110)
        org.kie.kogito.codegen.process.ProcessesContainerGenerator.addProcess(ProcessesContainerGenerator.java:104)
        org.kie.kogito.codegen.process.ProcessCodegen.generate(ProcessCodegen.java:282)
        org.kie.kogito.codegen.process.ProcessCodegen.generate(ProcessCodegen.java:64)
        org.kie.kogito.codegen.ApplicationGenerator.lambda$generateComponents$5(ApplicationGenerator.java:212)
      

      instead it should provide more meaningful error message that will allow users to quickly fix the issue.

              swiderski.maciej Maciej Swiderski (Inactive)
              swiderski.maciej Maciej Swiderski (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: