Uploaded image for project: 'Kogito'
  1. Kogito
  2. KOGITO-1578

Proposal: change "installInfinispan" and "installKafka" to "enablePersistence" and "enableEvents" respectively

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 0.9.0
    • 0.8.0
    • Operator
    • None
    • 2020 Week 13-15 (from Mar 23)

      Today we have the KogitoApp CR to enable persistence and events like this:

       
      apiVersion: app.kiegroup.org/v1alpha1
      kind: KogitoApp
      metadata:
        name: example-quarkus
      spec:
        infra:
          installInfinispan: Always
          installKafka: Always
        build:
          envs:
            - name: MAVEN_ARGS_APPEND
              value: "-Ppersistence,events"
          gitSource:
            contextDir: jbpm-quarkus-example
            uri: 'https://github.com/kiegroup/kogito-examples'
      

      Instead of relying on implementation, I propose a change focused on the capability, aligned with the Runtimes add-ons:

       
      apiVersion: app.kiegroup.org/v1alpha1
      kind: KogitoApp
      metadata:
        name: example-quarkus
      spec:
        enablePersistence: true
        enableEvents: true
        build:
          envs:
            - name: MAVEN_ARGS_APPEND
              value: "-Ppersistence,events"
          gitSource:
            contextDir: jbpm-quarkus-example
            uri: 'https://github.com/kiegroup/kogito-examples'
      

      So the CLI will be more aligned with the Runtime Services as well like:

      kogito deploy example-service --enable-persistence --enable-events
      

      The feature won't change, meaning that if it's not enabled, the user is responsible to deploy their persistence implementation and configure their deployed service. If enabled, the Operator will deploy and configure Infinispan and Kafka for the given service.

              rhn-support-zanini Ricardo Zanini
              rhn-support-zanini Ricardo Zanini
              Tristan Radisson Tristan Radisson
              Tristan Radisson Tristan Radisson
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: