Uploaded image for project: 'Kogito'
  1. Kogito
  2. KOGITO-1433

[VSCode] Dirty state not correctly updated after undo/redo on a recently saved diagram (new VSCode API (1.43.0))

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • None
    • None
    • None
    • Hide
      1. Open a process
      2. Do two changes (editor state dirty)
      3. Save (editor state clean)
      4. Undo a change (editor state dirty)
      5. Redo the change (editor state dirty -> WRONG! it should be clean here since we are back to the state where we saved. That's the default editor on VSCode text editor)
      6. Undo all changes (editor state clean -> WRONG! it should be dirty because we are on a different state than the one we saved)
      Show
      Open a process Do two changes (editor state dirty) Save (editor state clean) Undo a change (editor state dirty) Redo the change (editor state dirty -> WRONG! it should be clean here since we are back to the state where we saved. That's the default editor on VSCode text editor) Undo all changes (editor state clean -> WRONG! it should be dirty because we are on a different state than the one we saved)

    Description

      VSCode new api is handling dirty state of the asset but it gets not correctly updated after redoing commands on a recently saved diagram.

      If you make some changes on a process (editor becomes dirty) and save, the editor becomes clean. After that you can execute undo and the editor becoms dirty. It only becomes clean again after undoing all the changes and you reach the original state of the diagram not the state where you saved.

      The issue appears to be related to the VSCode API, but we may introduce some changes after the new API is released.

      Attachments

        Issue Links

          is related to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. KOGITO-1863 Adapt to new VSCode API 1.45.0

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              rh-ee-pefernan Pere Fernandez Perez
              rh-ee-pefernan Pere Fernandez Perez
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: