Uploaded image for project: 'Konflux UI'
  1. Konflux UI
  2. KFLUXUI-646

Kite: missing error handling in webhooks endpoint

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • Konflux

      In packages/backend/internal/handlers/http/webhook_handlers.go There is a check done in this line that may cause issues and cause the client to hang waiting for a response:

      resolved, err := h.issueService.ResolveIssuesByScope(c.Request.Context(), "pipelinerun", req.PipelineName, req.Namespace)
if err != nil {
    h.logger.WithError(err).Errorf("failed to resolve issues for pipeline run %s : %v", req.PipelineName, err)
    return  // This returns without sending any HTTP response!
}

      This should be fixed.

              Unassigned Unassigned
              bramos@redhat.com Bryan Ramos
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: