Uploaded image for project: 'JBoss Web Server'
  1. JBoss Web Server
  2. JWS-757

some tomcat-vault errors are ignored and not logged

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • JWS 5.0_RHEL DR1
    • None
    • tomcat-vault
    • None
    • Hide

      1) Install tomcat and configure tomcat-vault per the documentation
      2) Intentionally set a bad property substitution in an XML file (the vault block is missing below)

      $ tail -n2 conf/tomcat-users.xml
    <user username="tomcat" password="${VAULT::::password::}" roles="manager-gui"/>
</tomcat-users>

      3) An introspection error should occur and throw a IllegalArgumentException on line 283. The exception is thrown, but the Digester in tomcat catches and ignores it leaving the property substitution incomplete here.

      4) Observe that no error is logged but the substitution doesn't work. In my test that was proven because I couldn't login with the password stored in the vault.

      Show
      1) Install tomcat and configure tomcat-vault per the documentation 2) Intentionally set a bad property substitution in an XML file (the vault block is missing below) $ tail -n2 conf/tomcat-users.xml <user username="tomcat" password="${VAULT::::password::}" roles="manager-gui"/> </tomcat-users> 3) An introspection error should occur and throw a IllegalArgumentException on line 283 . The exception is thrown, but the Digester in tomcat catches and ignores it leaving the property substitution incomplete here . 4) Observe that no error is logged but the substitution doesn't work. In my test that was proven because I couldn't login with the password stored in the vault.

      I've found that some of the tomcat-vault errors are silently ignored, which makes it virtually impossible for users which have configuration issues to figure out why it isn't working...These errors should be logged along with the stack trace (and then ignored).

      There are also a ton of e.printStackTrace() calls in the library which aren't allowed in our products.

              rhn-support-csutherl Coty Sutherland
              rhn-support-csutherl Coty Sutherland
              Jan Onderka Jan Onderka
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: