-
Feature Request
-
Resolution: Done
-
Minor
-
2.4.4
-
None
BasicConnectionTable.readPeerAddress:
log.warn(new StringBuffer("packet from ").append(client_addr).append(':').append(client_port).
append(" has different version (").append(version).append(") from ours (").
append(Version.version).append("). This may cause problems"));
Should instead look like this:
log.warn(new StringBuffer("packet from ").append(client_addr).append(':').append(client_port).
append(" has different version (").append(version).append(") from ours (").
append(Version.print(Version.version)).append("). This may cause problems"));
Note the change from Version.version to Version.print(Version.version).
This is to enable easier debugging. The short version for 2.4.4 is 4356 which looks quite confusing at first
glance. A node saying that their version is 4356? Which one is it? The change would make it show 2.4.4
which is provides easier identification.