Uploaded image for project: 'JGroups'
  1. JGroups
  2. JGRP-2746

RouterStubManager/RouterStub: remove unneeded synchronization

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 5.3.2, 5.2.21
    • None
    • None
    • False
    • None
    • False

      There's synchronization around `RouterStubManager.stubs` that's not needed: `stubs` is never changed after initialization, so synchronization can be removed. Possibly use a CopyOnWrite list or a concurrent list

      `RouterStub.writeRequest()` is also synchronized, but it calls either `TcpConnection.send()` or `NioConnection.send()`, which are both protected by a lock, so we can remove synchronization on `writeRequest()`.

            rhn-engineering-bban Bela Ban
            rhn-engineering-bban Bela Ban
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: