-
Bug
-
Resolution: Done
-
Major
-
None
-
None
- 1.3.3. Limitations of Map Methods
I couldn't find the property infinispan.accurate.bulk.ops described in this chapter in any ISPN sources. It is available under JDG_6.6.0.GA-base tag, but seems that was removed in JDG7, eventhough I couldn't find the corresponding JIRA/commit which removes it.
- 4.3.2. Specify an Intrinsic Group - http://docbuilder.usersys.redhat.com/23162/#Specify_an_Intrinsic_Group
The Example 4.2. Specifying an Intrinsic Group Example doesn't compile, because there is excessive bracket:public int hashCode()) {
should be:
public int hashCode() {
- 6.1.2. Create a Customized Cache Using the Default Named Cache
The code given in Example "Procedure 6.2. Customize the Default Cache" doesn't compile. The variable cacheManager on line 2 should be manager.
Also could you please define the variable with name newCacheName on top before first line.
Also the steps described in points 3 and 4 are not correct. In point 3) in case you will define the newCacheName then in point 3) you can specify that new cache is registered with defined name. In case if you would like to specify the same name for the cache which is defined in the xml, then as far as I know the cache configuration which was defined in xml and was loaded by cachemanager will be overriden.
For point 4) {{... default cache with custom configuration .. }} is wrong. Either we are getting the newly registered cache or we are getting the cache defined in xml file with custom configuraiton.
The same refers to Procedure 6.3. Creating a Customized Cache Using a Non-Default Named Cache
- 6.1.5.3. Globally Customize Thread Pool Executors
The sample code given in Example 6.3. Customize Thread Pool Executors doesn't compile. The code is outdated - the replicationQueueScheduledExecutor() doesn't exist any more. And as far as I know there are no analog for it.
- Also I would like to mention the numbering for procedures - is it ok to have repeating numbers for the procedures like 6.1, 6.2, 6.3 then again 6.1 , 6.2 , etc ?
- 7.3.4. Register Multiple Externalizers
I couldn't find in the sources the annotation @Marshalls. Don't know if it is removed.
- 8.4.1. Cache Entry Modified Listener Configuration and 8.2 chapters are completely the same;
- 8.4.2. Cache Entry Modified Listener Example
The example 8.2 doesn't compile. Should be:@Listener public class PrintWhenModified { @CacheEntryModified public void print(CacheEntryModifiedEvent event) { System.out.println("Cache entry modified. Details = " + event); } }
- 8.5.2. The Cache Listener API
In the description of Cache API the sync attribute is not described, eventhough it is described in 8.3.3. Don't know if it is worthy to write about it again in 8.5.2.
- The Example 8.4. Use Case: Filtering and Converting the New York orders doesn't compile. Should be:
class CityStateFilter implements CacheEventFilter<String, Order> { private final String state; private final String city; public boolean accept(String orderId, Order oldOrder, Metadata oldMetadata, Order newOrder, Metadata newMetadata, EventType eventType) { switch (eventType.getType()) { // Only send update if the order is going to our city case Type.CACHE_ENTRY_CREATED: return city.equals(newOrder.getCity()) && state.equals(newOrder.getState()); // Only send update if our order has changed from our city to elsewhere or if is now going to our city case Type.CACHE_ENTRY_MODIFIED: if (city.equals(oldOrder.getCity()) && state.equals(oldOrder.getState())) { // If old city matches then we have to compare if new order is no longer going to our city return !city.equals(newOrder.getCity()) || !state.equals(newOrder.getState()); } else { // If the old city doesn't match ours then only send update if new update does match ours return city.equals(newOrder.getCity()) && state.equals(newOrder.getState()); } // On remove we have to send update if our order was originally going to city case Type.CACHE_ENTRY_REMOVED: return city.equals(oldOrder.getCity()) && state.equals(oldOrder.getState()); } return false; } } class OrderDateConverter implements CacheEventConverter<String, Order, Date> { private final String state; private final String city; public Date convert(String orderId, Order oldValue, Metadata oldMetadata, Order newValue, Metadata newMetadata, EventType eventType) { // If remove we do not care about date - this tells listener to remove its data if (eventType.isRemove()) { return null; } else if (eventType.isModified()) { if (state.equals(newValue.getState()) && city.equals(newValue.getCity())) { // If it is a modification meaning the destination has changed to ours then we allow it return newValue.getDate(); } else { // If destination is no longer our city it means it was changed from us so send null return null; } } else { // This was a create so we always send date return newValue.getDate(); } } }
- 8.5.4. Optimized Cache Filter Converter
The Example 8.5. CacheEventFilterConverter doesn't compile. The code should be:class OrderDateFilterConverter extends AbstractCacheEventFilterConverter<String, Order, Date> { private final String state; private final String city; public Date filterAndConvert(String orderId, Order oldValue, Metadata oldMetadata, Order newValue, Metadata newMetadata, EventType eventType) { // Remove if the date is not required - this tells listener to remove its data if (eventType.isRemove()) { return null; } else if (eventType.isModified()) { if (state.equals(newValue.getState()) && city.equals(newValue.getCity())) { // If it is a modification meaning the destination has changed to ours then we allow it return newValue.getDate(); } else { // If destination is no longer our city it means it was changed from us so send null return null; } } else { // This was a create so we always send date return newValue.getDate(); } } }
- 8.6.1. Adding and Removing Event Listeners
In this chapter the subtitle "Registering and Event Listener with the Server" should be "Registering an Event Listener with the Server" - 8.6.2. Remote Event Client Listener Example
In this chapter, the version for infinispan is written "6.3.0-Final-redhat-1 or better". Wanted to make sure if the version should correspond to infinispan version in JDG7. - In Example 8.9. KeyValueFilter code doesn't compile. The getKeyValueFilter should be replaced with getFilter. The same refers to Example 8.12. Configuring an Enhanced Filter Factory.
- In Example 8.14. Sending Custom Events the return new ValueAddedEvent(key, value); line should be return new ValueAddedEvent(key, newValue);
- In Procedure 9.1. Embedded Mode the infinispan-embedded-8.3.0.ER4-redhat-1.jar should be infinispan-embedded-8.3.0.Final-redhat-1.jar
- In Procedure 9.2. Remote Mode jboss-datagrid-7.0.0-remote-java-client/infinispan-remote-8.3.0.ER4-redhat-1.jar should be replaced with jboss-datagrid-7.0.0-remote-java-client/lib/infinispan-remote-8.3.0.Final-redhat-1.jar
- In Library Mode the following sentence is not clear:
This allows the opportunity to define clustered caches, which a reference can be later obtained to using the CacheManager.getCache method; otherwise local caches can only be used, created from the CacheManager.createCache.
- In Example 10.6. Using a Java Main Method the last curly bracket should be removed.