Uploaded image for project: 'JBoss Web Services'
  1. JBoss Web Services
  2. JBWS-3851

WSDL publisher incorrectly attempt to publish external HTTPS schema import

      WSDL publisher incorrectly attempt to publish external HTTPS schema import

      See lone 210 in src/main/java/org/jboss/ws/common/utils/AbstractWSDLFilePublisher.java
      repo https://svn.jboss.org/repos/jbossws/common/trunk

      210 if (schemaLocation.length() > 0 && schemaLocation.startsWith("http://")

      This should be

      210 if (schemaLocation.length() > 0 && schemaLocation.startsWith("http://") == false && schemaLocation.startsWith("https://") == false)

      This is related to https://issues.jboss.org/browse/JBWS-3827

            [JBWS-3851] WSDL publisher incorrectly attempt to publish external HTTPS schema import

            r searls added a comment -

            Code change checked in.
            https://svn.jboss.org/repos/jbossws/common/trunk (version 3.0.0-SNAPSHOT)
            Committed revision 19034.

            — diff
            — src/main/java/org/jboss/ws/common/utils/AbstractWSDLFilePublisher.java (revision 19033)
            +++ src/main/java/org/jboss/ws/common/utils/AbstractWSDLFilePublisher.java (working copy)
            @@ -207,7 +207,7 @@
            final String ln = childElement.getLocalName();
            if ("import".equals(ln) || "include".equals(ln)) {
            String schemaLocation = childElement.getAttribute("schemaLocation");

            • if (schemaLocation.length() > 0 && schemaLocation.startsWith("http://") == false)
              + if (schemaLocation.length() > 0 && schemaLocation.startsWith("http://") == false && schemaLocat
              ion.startsWith("https://") == false)
              {
              // infinity loops prevention
              if (!published.contains(schemaLocation))

            r searls added a comment - Code change checked in. https://svn.jboss.org/repos/jbossws/common/trunk (version 3.0.0-SNAPSHOT) Committed revision 19034. — diff — src/main/java/org/jboss/ws/common/utils/AbstractWSDLFilePublisher.java (revision 19033) +++ src/main/java/org/jboss/ws/common/utils/AbstractWSDLFilePublisher.java (working copy) @@ -207,7 +207,7 @@ final String ln = childElement.getLocalName(); if ("import".equals(ln) || "include".equals(ln)) { String schemaLocation = childElement.getAttribute("schemaLocation"); if (schemaLocation.length() > 0 && schemaLocation.startsWith("http://") == false) + if (schemaLocation.length() > 0 && schemaLocation.startsWith("http://") == false && schemaLocat ion.startsWith("https://") == false) { // infinity loops prevention if (!published.contains(schemaLocation))

            r searls added a comment -

            This issue is the same as for https://issues.jboss.org/browse/JBWS-3827 except it is for a
            schema import and not a wsdl import.

            r searls added a comment - This issue is the same as for https://issues.jboss.org/browse/JBWS-3827 except it is for a schema import and not a wsdl import.

              rsearls r searls
              rsearls r searls
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: