Uploaded image for project: 'JBoss Web Services'
  1. JBoss Web Services
  2. JBWS-2895 Provide JAX-RPC features on top of stacks not having them
  3. JBWS-2899

Remove WSAspectizedDeployersFactory from stack specific configs

XMLWordPrintable

      The following commit breaks AS IL abstraction and since now all stacks are using it directly not via SPI:

      On 01/25/2010 11:21 AM, jbossws-commits@lists.jboss.org wrote:
      > Author: alessio.soldano@jboss.com
      > Date: 2010-01-25 05:21:43 -0500 (Mon, 25 Jan 2010)
      > New Revision: 11480
      >
      > Modified:
      > stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/ws/extensions/wsrm/server/RMDeploymentAspect.java
      > stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/EagerInitializeDeploymentAspect.java
      > stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/EventingDeploymentAspect.java
      > stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/PublishContractDeploymentAspect.java
      > stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/ServiceEndpointInvokerDeploymentAspect.java
      > stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/UnifiedMetaDataDeploymentAspect.java
      > stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml
      > Log:
      > Using new AbstractDeploymentAspect + moving WSAspectizedDeployerFactory to stack specific config file
      >
      > Modified: stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml
      > ===================================================================
      > — stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml 2010-01-25 10:15:58 UTC (rev 11479)
      > +++ stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml 2010-01-25 10:21:43 UTC (rev 11480)
      > @@ -2,6 +2,17 @@
      >
      > <deployment xmlns="urn:jboss:bean-deployer:2.0">
      >
      > + <!-- WSDeploymentAspectDeployers factory -->
      > + <bean name="WSAspectizedDeployersFactory" class="org.jboss.webservices.integration.deployers.WSAspectizedDeployersFactory">
      > + <constructor>
      > + <parameter>
      > + <inject bean="Deployers"/>
      > + </parameter>
      > + </constructor>
      > + <incallback method="addDeployer"/>
      > + <uncallback method="removeDeployer"/>
      > + </bean>
      > +
      > <!-- The registry for web service endpoints -->
      > <bean name="WSEndpointRegistry" class="org.jboss.wsf.framework.management.ManagedEndpointRegistry">
      > <property name="mbeanServer"><inject bean="WSMBeanServerLocator" property="mbeanServer"/></property>
      >
      > _______________________________________________
      > jbossws-commits mailing list
      > jbossws-commits@lists.jboss.org
      > https://lists.jboss.org/mailman/listinfo/jbossws-commits

      I know this is just a prototype ATM but before before merging to trunks it should be fixed.
      AFAIR it is somehow related to the class loaders hack in WSDeploymentAspectDeployer.

      I suggest the following solution instead of the aforementioned one:

      • move WSAspectizedDeployersFactory back to stack-agnostic-jboss-beans.xml
      • in WSDeploymentAspectDeployer.internalUn/Deploy() methods do:

      final ClassLoader oldCL = Thread.currentThread().getContextClassLoader(); // TODO: protect with security actions helper class
      final ClassLoader newCL = this.aspect.getClass().getClassLoader();
      try {
      Thread.currentThread().setContextClassLoader(newCL); // TODO: protect with security actions helper class
      this.aspect.start(dep);
      } finally {
      Thread.currentThread.setContextClassLoader(oldCL); // TODO: protect with security actions helper class
      }

              rhn-support-asoldano Alessio Soldano
              ropalka Richard Opalka
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: