Uploaded image for project: 'JBoss Web Services'
  1. JBoss Web Services
  2. JBWS-2395

Maven Refactoring Damaged Many wstools tests

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • jbossws-native-3.0.5
    • jbossws-native-3.0.4
    • tools-jaxrpc
    • None

      Previously many of the tests in the package 'org.jboss.test.ws.tools' used the following two variables: -

      String resourceDir = "resources/tools/jbws1079";
      String toolsDir = "tools/jbws1079";

      The 'resourcesDir' is where the base source and descriptors live as the expected results of the test, the 'toolsDir' is where the new source is generated when the test runs.

      After the maven refactoring we have: -

      File resourceFile = createResourceFile("tools/jbws1079");
      String resourceDir = resourceFile.getAbsolutePath();
      String toolsDir = resourceDir;

      The resourceDir and toolsDir are now the same.

      This is not a problem for the source code as the expected source is not in a package structure whilst the generated code is so these do not conflict.

      However for the comparison of the mapping files: -

      mappingValidator.validate(resourceDir + "/anonymous-mapping.xml", toolsDir + "/anonymous-mapping.xml");

      We end up checking if a file is identical to itself which of course passes.

              darran.lofthouse@redhat.com Darran Lofthouse
              darran.lofthouse@redhat.com Darran Lofthouse
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: