Uploaded image for project: 'JBoss Transaction Manager'
  1. JBoss Transaction Manager
  2. JBTM-3974

Remove the deprecated ObjStoreBrowser constructor and change the modifier of the default one

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • 7.later
    • None
    • None
    • None

      The ObjStoreBrowser (https://github.com/jbosstm/narayana/blob/main/ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/tools/osb/mbean/ObjStoreBrowser.java) class is a singleton so it is preferable to use a static method to retrieve the instance (getInstance method). Please change the contructor to private to align at the singleton pattern.
      Please consider removing the constructor accepting the logDir parameter because the store directory should be set as 'arjPropertyManager.getObjectStoreEnvironmentBean().setObjectStoreDir("logDir");'
      Please note that this is an API change and needs a major release.
      Additionally the ObjectStoreEnvironmentBean:::setObjectStoreDir could be seen as slightly different use case to what the OSB would use it for: possibly an OSB user wants to connect to a different object store than the one that the transaction manager in memory is configured to use. Since that case is probably very rare and (I think) misleading it is better relying on the field 'ObjectStoreEnvironmentBean.setObjectStoreDir'. That being said, we would want a release note for it so we make sure the impact is clear.

              Unassigned Unassigned
              rh-ee-msappegr Marco Sappe Griot
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: