Uploaded image for project: 'JBoss Transaction Manager'
  1. JBoss Transaction Manager
  2. JBTM-3897

Review com.arjuna.ats.arjuna.coordinator.ActionManager

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Major Major
    • 7.1.0.Final
    • 7.0.2.Final
    • Transaction Core
    • None

      Review com.arjuna.ats.arjuna.coordinator.ActionManager. In particular:

      • Remove the `getTimeAdded` method (which was deprecated a long time ago)
      • As a consequence of the previous point, the `Lifetime` class can be deprecated/removed (as it is an internal class, I vote for removing it)
      • Remove the `final` keyword from the static method `manager`
      • `_allActions` doesn't need to be static (as ActionManager is Singleton)
      • Reformat the whole ActionManager class (if it is preferred a dedicated JBTM for this point, please create a subtask within this issue tracker)

      Reason to review this class: `ActionManager.getTimeAdded` has been deprecated for a long time and we should take the next step we already announced (i.e. remove it). As the Lifetime class is an internal class and it is only used in `getTimeAdded`, we should also remove that class and simplify the Map that use it

            jfinelli@redhat.com Manuel Finelli
            jfinelli@redhat.com Manuel Finelli
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: