Uploaded image for project: 'JBoss Transaction Manager'
  1. JBoss Transaction Manager
  2. JBTM-3390

Clarify usage of lraUid versus lraId in the code

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 5.11.0.Final
    • 5.10.6.Final
    • LRA
    • None
    • Hide

      As part of the JBTM-3378 there was created a unified method for for getting LRA uid from the LRA id. This method was put under LRAConstants as method getLRAid.
      This is a wrong name as the method extracts the uid part of the LRA id. It needs to be renamed for not making misunderstanding of the code.

      On top of it it may throw NPE when the provided LRA id - which is represented by URI - does not contain path component. There should not be NPE but rather some descriptive RuntimeException being used.

      Show
      As part of the JBTM-3378 there was created a unified method for for getting LRA uid from the LRA id. This method was put under LRAConstants as method getLRAid . This is a wrong name as the method extracts the uid part of the LRA id. It needs to be renamed for not making misunderstanding of the code. On top of it it may throw NPE when the provided LRA id - which is represented by URI - does not contain path component. There should not be NPE but rather some descriptive RuntimeException being used.
    • Undefined

            ochaloup@redhat.com Ondrej Chaloupka (Inactive)
            ochaloup@redhat.com Ondrej Chaloupka (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: