Uploaded image for project: 'JBoss Transaction Manager'
  1. JBoss Transaction Manager
  2. JBTM-2065

TestExternManageDestination::test_stored_message_schedule() hangs on Windows

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 5.0.1
    • None
    • BlackTie
    • None

            [JBTM-2065] TestExternManageDestination::test_stored_message_schedule() hangs on Windows

            Tom Jenkinson added a comment -

            Thanks for the hard work on this one!

            Tom Jenkinson added a comment - Thanks for the hard work on this one!

            Tom Jenkinson added a comment -

            PR submitted to revert the disabling of the test

            Tom Jenkinson added a comment - PR submitted to revert the disabling of the test

            Tom Jenkinson added a comment -

            Thanks for the update Clebert. What we do generally is revert the disabled test, run a PR over that then merge it. I will raise the PR on our repo.

            Tom Jenkinson added a comment - Thanks for the update Clebert. What we do generally is revert the disabled test, run a PR over that then merge it. I will raise the PR on our repo.

            Clebert Suconic added a comment -

            It has been merged.. should you close this issue now?

            Clebert Suconic added a comment - It has been merged.. should you close this issue now?

            Clebert Suconic added a comment -

            https://github.com/wildfly/wildfly/pull/5816

            Clebert Suconic added a comment - https://github.com/wildfly/wildfly/pull/5816

            Tom Jenkinson added a comment -

            Thanks Clebert! Will 2.4.1 make WildFly 8 do you know?

            Tom Jenkinson added a comment - Thanks Clebert! Will 2.4.1 make WildFly 8 do you know?

            Clebert Suconic added a comment -

            https://github.com/hornetq/hornetq/pull/1507

            I will cut 2.4.1 tomorrow my morning (US EST)

            Clebert Suconic added a comment - https://github.com/hornetq/hornetq/pull/1507 I will cut 2.4.1 tomorrow my morning (US EST)

            Clebert Suconic added a comment -

            The issue was that on windows. a scheduleImpl.schedule(Runnable, delay, MILLISECONDS) could finish earlier than expected.

            I added a workaround to the scheduler, with this following trace:

            calling another scheduler now as deliverTime " + deliveryTime + " < now=" + now

            which is happening quite a lot on the windows box that was failing.

            The test was replicated in loop and after this fix we couldn't make it fail again

            Clebert Suconic added a comment - The issue was that on windows. a scheduleImpl.schedule(Runnable, delay, MILLISECONDS) could finish earlier than expected. I added a workaround to the scheduler, with this following trace: calling another scheduler now as deliverTime " + deliveryTime + " < now=" + now which is happening quite a lot on the windows box that was failing. The test was replicated in loop and after this fix we couldn't make it fail again

            Zheng Feng added a comment -

            yeah, I just setup the job http://172.17.131.2/view/Narayana+BlackTie-JBTM/job/JBTM-2065
            It uses the HornetQ master branch which is 2.5.0-SNAPSHOT and pick the commit from git://github.com/hornetq/wildfly.git

            Zheng Feng added a comment - yeah, I just setup the job http://172.17.131.2/view/Narayana+BlackTie-JBTM/job/JBTM-2065 It uses the HornetQ master branch which is 2.5.0-SNAPSHOT and pick the commit from git://github.com/hornetq/wildfly.git

            Tom Jenkinson added a comment -

            As agreed on the phone, we should set up a job on here to have this replicated and set up such that it can build HQ branches before it runs our normal build:
            http://172.17.131.2/view/Narayana+BlackTie-JBTM/

            We will need a WildFly branch set up in the jbosstm user that has cleberts snapshot referenced.

            Tom Jenkinson added a comment - As agreed on the phone, we should set up a job on here to have this replicated and set up such that it can build HQ branches before it runs our normal build: http://172.17.131.2/view/Narayana+BlackTie-JBTM/ We will need a WildFly branch set up in the jbosstm user that has cleberts snapshot referenced.

              zfeng@redhat.com Zheng Feng
              zfeng@redhat.com Zheng Feng
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: